Skip to content
This repository was archived by the owner on Feb 22, 2022. It is now read-only.

[stable/prometheus-redis-exporter] Update image #15217

Merged
merged 1 commit into from
Jul 8, 2019
Merged

[stable/prometheus-redis-exporter] Update image #15217

merged 1 commit into from
Jul 8, 2019

Conversation

naseemkullah
Copy link
Collaborator

Signed-off-by: Naseem [email protected]

What this PR does / why we need it:

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer:

Please see release notes, particularly for v1.0.0 as it states some breaking changes:
https://github.com/oliver006/redis_exporter/releases/tag/v1.0.0

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/chart])

@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 2, 2019
@acondrat
Copy link
Collaborator

acondrat commented Jul 2, 2019

Hi @naseemkullah
What about scraping multiple targets? Looks like this is no longer supported, at least not in the way it used to work. I suppose we need to adapt to those change before moving forward.
Any ideas?

@naseemkullah
Copy link
Collaborator Author

True.
I agree we should adapt these changes, probably bump the major version of this chart. I think all this entails is accepting a single value for redisAddress rather than a list of values (unless I am missing something?), and adding an Upgrading section to this chart to forewarn about the breaking change, referencing this PR as well as the relevant section in redis_exporter's README.

@helm-bot helm-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 8, 2019
Signed-off-by: Naseem <[email protected]>
Copy link
Collaborator

@acondrat acondrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 8, 2019
@acondrat
Copy link
Collaborator

acondrat commented Jul 8, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: acondrat, naseemkullah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit b7bba20 into helm:master Jul 8, 2019
@naseemkullah naseemkullah deleted the prom-redis-exp-image branch July 8, 2019 22:48
ThoTischner pushed a commit to bitsbeats/charts that referenced this pull request Aug 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants