Refactor ECDSA Key Handling using Java Security #983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replaced Bouncy Castle with Java Security components for ECDSA Key Specifications
hierynomus
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors construction of ECDSA public and private key objects using standard Java Cryptography Architecture classes in place of Bouncy Castle classes.
These changes address some of the concerns raised in issue #973, reducing direct references to the Bouncy Castle library. Separate work is required to address other Bouncy Castle references.
The implementation introduces a new shared
ECDSAKeyFactoryclass with methods for constructingPrivateKeyandPublicKeyobjects from source material and the associated NIST Elliptic Curve. This approach reduces duplicated code from several methods that create ECDSA key objects.