Remove Bouncy Castle usage from Tests #984
Open
+61
−66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed unnecessary addition of Bouncy Castle Provider from several tests - Replaced Bouncy Castle Hex.toHexString() with SSHD BufferUtils.toHex()
exceptionfactory
force-pushed
the
bouncy-castle-test-removal-1
branch
from
d824b32 to
fc44542
Compare
|
@hierynomus This pull request is one of several, including #989 and #993 designed reduce or remove direct references to the Bouncy Castle library. This particular change should be the most straightforward, since it is focused on changing tests as opposed to runtime components. As you have availability to review, this would be useful for a number of integrations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes Bouncy Castle class references from tests.
Some changes involve removing unnecessary registration of the
BouncyCastleProviderin several tests, and replacing the Bouncy CastleHex.toHexString()with Apache SSHDBufferUtils.toHex()in other test cases.This relates to a broader effort described in issue #973 for reducing usage of Bouncy Castle in general.