Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(data): refactor train mask, supports more fine-grained mask for ShareGPT #7264

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor(data): refactor train mask, supports more fine-grained mask for ShareGPT #7264

wants to merge 1 commit into from
+36 −22

Conversation

zzc0430
Copy link

@zzc0430 zzc0430 commented Mar 12, 2025

What does this PR do?

(Same as #6498) refactor train mask, supports more fine-grained mask for ShareGPT

  • supports more fine-grained train mask for ShareGPT
  • Unified the two control methods for the mask: data_args(mask_history, train_on_prompt) and dataset_attr(sharegpt: train).
  • Do not reverse messages when mask_history is set to True

Before submitting

@hiyouga hiyouga added the pending This problem is yet to be addressed label Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pending This problem is yet to be addressed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zzc0430 @hiyouga