fix: tables with zero columns break theme/font stack #2472
+16
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: Pull Request
about: Create a pull request to help us improve
title: A table without columns breaks font/theme stack
assignees: @hoffstadt
Closes #2075
Description:
A table with no columns and a theme or font (however weird that sounds) puts the theme/font onto the stack but does not remove it, thus breaking styles everywhere else.
This PR moves the check for no-columns to the top of the
draw()method (it actually checks for "no visible columns" -- this condition was added in DPG 2.0, we just need to perform the check earlier, before applying the theme/font).Concerning Areas:
None.