Skip to content

[Don't Merge] Feature: drain sockets on a dedicated "reader" thread #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 27 commits into
base: main
Choose a base branch
from
Open

[Don't Merge] Feature: drain sockets on a dedicated "reader" thread #241

wants to merge 27 commits into from

Conversation

telamon
Copy link

@telamon telamon commented Jan 9, 2025 •
edited
Loading

  • added unobtrusive build option USE_DRAIN_THREAD. default: disabled

telamon added 19 commits December 6, 2024 06:37
@telamon
wip; added secondary thread + poller
92c75f8
@telamon
wip; drained via udx__recvmsg() from worker thread
312c403
@telamon
WIP; hello test passed
a6cc9de
@telamon
Merge remote-tracking branch 'origin/main' into feat/threaded_drain
cc3e8f5
@telamon
WIP; restructured initial hack and added missing calls
9e36ec2
@telamon
WIP; attempted to measure drop using udxperf.c
9fc1c82
@telamon
wip; exit examples/server
50d2baf
@telamon
WIP; reproducing bugs
c1a070b
@telamon
WIP; refocused on k-drops
6afd5f7
@telamon
WIP; Fixed some miscalculations, still drop is still not relational
88554b3
@telamon
WIP; begun redoing load model
b63543d
@telamon
threadsafe command queue
c11bb27
@telamon
WIP; sync thread lifecycle with udx
b3f1805
@telamon
cleanup
ade96af
@telamon
Merge branch 'main' into feat/threaded_drain
1003ad8
@telamon
removed changes unrelated to feature
157c6fa
@telamon
wip; fixing synchronity
cbca639
@telamon
All tests pass
8841425
@telamon
sorted handle initalization onto correct threads
de0802b
@telamon telamon changed the title [wait] Feature: dedicated thread to drain socket recv bufffer Feature: dedicated thread to drain socket recv bufffer Jan 11, 2025
@telamon telamon changed the title Feature: dedicated thread to drain socket recv bufffer Feature: dedicated thread to drain socket's recive buffer Jan 11, 2025
@telamon telamon changed the title Feature: dedicated thread to drain socket's recive buffer Feature: drain sockets on a dedicated "reader" thread Jan 11, 2025
telamon added 2 commits March 17, 2025 01:37
@telamon
add missing initalization of udx.thread and socket
7c2e3ad 
There are still issues
@telamon
rewritten against udx-native testsuite
6085efc 
- add thread state `CLOSING`
- change leaky `thread->queue` into lockfree ringbuffer
- fixed thread initialization
- add `ASSERT_RUNS_ON_THREAD` and `ASSERT_RUNS_ON_MAIN`
- add boatload of asserts
@telamon telamon changed the title Feature: drain sockets on a dedicated "reader" thread [Don't Merge] Feature: drain sockets on a dedicated "reader" thread Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mafintosh mafintosh Awaiting requested review from mafintosh

@jthomas43 jthomas43 Awaiting requested review from jthomas43

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@telamon @jthomas43