Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

native node async/await test #71

Closed
toshok opened this issue Jul 24, 2018 · 3 comments
Closed

native node async/await test #71

toshok opened this issue Jul 24, 2018 · 3 comments
Labels
type: maintenance The necessary chores to keep the dust off.

Comments

@toshok
Copy link
Contributor

toshok commented Jul 24, 2018

context doesn't seem to get propagated for native node async/await usage.
@toshok
Copy link
Contributor Author

toshok commented Jul 24, 2018

This looks relevant nodejs/node#20404

@toshok toshok added the type: maintenance The necessary chores to keep the dust off. label Aug 2, 2018
@BrianChristie
Copy link

Looks like nodejs/node#20404 is a duplicate of nodejs/node#20274

One of the comments on 20274 says:

It looks like this is fixed in 10.4.0 with the update of V8 from 6.6 to 6.7

@toshok toshok mentioned this issue Aug 10, 2018
Merged
toshok added a commit that referenced this issue Aug 10, 2018
@toshok
fix async hooks breakage on early v10 (#87)
4c9f846 
Turns out the code in #82 is necessary for at least early v10 usage (see #71 (comment)).

We do need a better story about conditional/version-specific instrumentation?  see #86.

this PR reverts #82 and adds node 10.0.0 to the build matrix (which fails without this revert)
@vreynolds
Copy link
Contributor

Hello,

We will be closing this issue as it is a low priority for us. It is unlikely that we'll ever get to it, and so we'd like to set expectations accordingly.

As we enter 2022 Q1, we are trimming our OSS backlog. This is so that we can focus better on areas that are more aligned with the OpenTelemetry-focused direction of telemetry ingest for Honeycomb.

If this issue is important to you, please feel free to ping here and we can discuss/re-open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: maintenance The necessary chores to keep the dust off.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@toshok @BrianChristie @vreynolds