feat(slo): add md slo support for slo data source #635
Conversation
|
@jharley in the screenshot the dataset field returns a null value. should we return something to the dataset field when its omitted from the config? spoke with Madhu about it but we're not sure if anything might be relying on a value being returned? and if so, what would we make the value for MD SLOs, would it just be "all"? |
There was a problem hiding this comment.
Great first pass at this! A few comments for clarity and tiding up.
in the screenshot the dataset field returns a null value. should we return something to the dataset field when its omitted from the config?
I think that's to be expected -- you can even assert it in your MD SLO test. There's no way to not return an attribute in Terraform as far as I know and null feels more correct to me than all
| resource.TestCheckResourceAttr("data.honeycombio_slo.test", "sli", slo.SLI.Alias), | ||
| resource.TestCheckResourceAttr("data.honeycombio_slo.test", "target_percentage", "99.5"), | ||
| resource.TestCheckResourceAttr("data.honeycombio_slo.test", "time_period", "30"), | ||
| resource.TestCheckNoResourceAttr("data.honeycombio_slo.test", "dataset"), |
| @@ -54,6 +56,89 @@ data "honeycombio_slo" "test" { | |||
| resource.TestCheckResourceAttr("data.honeycombio_slo.test", "sli", slo.SLI.Alias), | |||
| resource.TestCheckResourceAttr("data.honeycombio_slo.test", "target_percentage", "99.5"), | |||
| resource.TestCheckResourceAttr("data.honeycombio_slo.test", "time_period", "30"), | |||
| resource.TestCheckResourceAttr("data.honeycombio_slo.test", "dataset", dataset), | |||
Co-authored-by: Jason Harley <[email protected]>
Which problem is this PR solving?
https://app.asana.com/1/72322038700732/project/1205961717360815/task/1205427815943458?focus=true
Short description of the changes
Adds Multi Dataset support for SLO data source
How to verify that this has the expected result
Added unit tests to ensure SLO read with
data honeycombio_slois still possible with optional dataset argument for MD SLOsManual Verifications:
MD SLO:
Single SLO w/dataset argument:
Single SLO w/o dataset argument:
