Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove blank line that made my erblint unhappy #45

Merged
merged 1 commit into from
Dec 10, 2022

Conversation

drnic
Copy link
Contributor

@drnic drnic commented Dec 9, 2022

My app's erblint-ing was also looking into .erb files in node_modules and found something that made it unhappy.

Before PR:

$ erblint --lint-all --enable-linters space_around_erb_tag,extra_newline
.erb-lint.yml not found: using default config
Linting 70 files with 2 linters...

Extra blank line detected.
In file: test/dummy/app/views/frames/increment/button_in_frame.html.erb:37

1 error(s) were found in ERB files

After:

erblint --lint-all --enable-linters space_around_erb_tag,extra_newline
.erb-lint.yml not found: using default config
Linting 70 files with 2 linters...

No errors were found in ERB files

@hopsoft hopsoft merged commit 5540f91 into hopsoft:main Dec 10, 2022
@drnic drnic deleted the erblint-error branch December 10, 2022 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants