Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added exception throw on unsupported Exec names #118

Merged
merged 4 commits into from
May 9, 2024
Merged

Conversation

JakubTrzcskni
Copy link

@JakubTrzcskni JakubTrzcskni commented Apr 16, 2024

Before, it was possible to run OGL with a typo in the executor name argument, which resulted in passing an empty exec pointer without any error description. Now the ExecutorHandler.H throws an invalid argument error just like e.g. the Preconditioner.H handler

Copy link
Collaborator

@greole greole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please also add a short description to the PR.

@@ -1,3 +1,5 @@
# 0.5.4 (2024/04/10)
- Notify user of a unsupported executor argument [PR #]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Notify user of a unsupported executor argument [PR #]
- Notify user of a unsupported executor argument [PR #118](https://github.com/hpsim/OGL/pull/118/files)

@greole greole merged commit 4a8abde into hpsim:dev May 9, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants