Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic working module #2

Closed
wants to merge 6 commits into from
Closed

Basic working module #2

wants to merge 6 commits into from

Conversation

stijnhau
Copy link

After these changes the module can snet messages and the outbox is working.
Isn' complete at the moment but wanted to share to work already done.

@ojhaujjwal
Copy link
Member

Initially I had a lot of plan with this module. But, I have cancelled all those plans. Because, I am hell of busy right now. Also, this module has a lot flaws that I detected. So, after I have some time, I will rewrite it.

And, Thanks for the PR.

@ojhaujjwal
Copy link
Member

This module has a lot of flaws. To list out a few:

  1. Dependent on ZfcUser. ZfcUser should be optional
  2. This module should be simple. Contains column like is_starred. This is not necessary every time.
  3. Uses Zend\Db. I think this module should not work with Zend\Db but only with Doctrine and Propel.
  4. No support for Threaded conversations
    .............................................
    .............................................

@stijnhau
Copy link
Author

Indeed but the dependency oif ZfcUser isn't that bad for my current project.
The dependency on zend/DB should be a posibility to use that one or entity but that is something i'll wana do later on rather first get a working copy of it.

@ojhaujjwal
Copy link
Member

So, the best way for you is just to use forked version of this module for your current project.
It may take months for me to rewrite because of lack of time.
I want to create something like FOSMessageBundle. But, I don`t want to reinvent the wheel.

@ojhaujjwal ojhaujjwal closed this May 10, 2014
@stijnhau
Copy link
Author

Oke

i decided to remove my fork because i will make a new module of it.
With a new name so you can keep using this name for your module.
i hope i get time to rename it soon.

@stijnhau
Copy link
Author

https://github.com/stijnhau/PrivateMessaging/
Is the name of the new module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants