Skip to content

Replace Snow with Snowscape #709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2025
Merged

Conversation

shrianshChari
Copy link
Contributor

Resolves compatibility issues created by smogon/pokemon-showdown@deda1db

Alternatively, we can edit the fromshowdownmessage method to try and turn messages that are read in as "Snowscape" to also return Weather.SNOW, which would maintain compatibility with older builds of the Showdown server.

@shrianshChari shrianshChari changed the title Rename Weather.SNOW to Weather.SNOWSCAPE Replace Snow with Snowscape Mar 5, 2025
@hsahovic
Copy link
Owner

hsahovic commented Mar 7, 2025

Thanks @shrianshChari ! I agree we could try keeping this backwards-compatible. I will merge this to fix the current situation, but If you want to follow up with the other change, I'll happily merge it as well.

Copy link

codecov bot commented Mar 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.27%. Comparing base (f458350) to head (de93636).
Report is 131 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #709      +/-   ##
==========================================
+ Coverage   83.38%   84.27%   +0.88%     
==========================================
  Files          39       42       +3     
  Lines        3918     4432     +514     
==========================================
+ Hits         3267     3735     +468     
- Misses        651      697      +46     
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hsahovic hsahovic merged commit e6ced86 into hsahovic:master Mar 7, 2025
4 of 9 checks passed
@shrianshChari shrianshChari deleted the patch-1 branch March 7, 2025 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants