Fix excess warnings about <style> outside of <head> #1135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no way to silence warnings [*]: > $ tidy -q -e foo.html > line 7 column 9 - Warning: moved <style> tag to <head>! fix-style-tags: no to avoid. > $ tidy -q -e --fix-style-tags no foo.html > line 7 column 9 - Warning: found <style> tag in <body>! fix-style-tags: yes to move. As far as I can find, there was potential that <style> would be allowed here and this never happened. So I think defaulting "yes" is the root problem here. This patch makes the behaviour more like existing tags. By default raise a warning; when a tag is misplaced. The addition of "fix-style-tags: yes" automatically fixes it and silences the warning. I also considered to warn about the behaviour until the user expresses their intention with fix-style-tags. This was suggested in [*] but cfgBool() as no way to return 'unset', and the chosen solution seems "more correct". Downside of this patch is it changes behaviour, seen in patches to regression test 6_1_1_2. [*] htacg#730
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully to do the right thing with #730, see notes in the commit message.