fix disableOnBackPress #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks for the PR @zachrnolan! this LGTM, would you mind resolving the conflicts and I'll merge it? |
|
@bodyflex resolved, thanks for merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like there was some back and forth on this code, but I think this is the best solution.
We should only consider
disableOnBackPressif the modal is open, otherwise, you run the risk of disabling the Android hardware back button app-wide.If the modal is open and
disableOnBackPressis false, we close the modal and stop the hardware back button from going back a screen.If the modal is open and
disableOnBackPressis true, we do not close the modal and stop the hardware back button from going back a screen. This allows us to force the user to tap a button on the modal to close or perform other actions.Let me know if there are any use cases I'm not thinking about.