Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Occurences of Context<Data> should be renamed to Context<State> #259

Closed
fairingrey opened this issue May 22, 2019 · 1 comment
Closed

Occurences of Context<Data> should be renamed to Context<State> #259

fairingrey opened this issue May 22, 2019 · 1 comment
Labels
good first issue Good for newcomers

Comments

@fairingrey
Copy link
Contributor

fairingrey commented May 22, 2019 •
edited
Loading

Follow-up to #255 (comment)

Following the change by https://github.com/rustasync/tide/blob/master/rfcs/001-app-new.md, when implementing new context extension traits ContextExt, the associated type on Context should not be named Data but instead State. This would help improve clarity while keeping the semantics the same.

This search should have most of them
@fairingrey fairingrey added the good first issue Good for newcomers label May 22, 2019
@Maniarr Maniarr mentioned this issue May 22, 2019
Merged
8 tasks
@fairingrey
Copy link
Contributor Author

closed by #260

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fairingrey