Core revamp part 3 #255
Merged
Core revamp part 3 #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great! Although I will remark that we should probably rename all occurrences of Unrelated, given, but just something I've noticed that we haven't fully accounted for. |
|
@fairingrey - I think a separate PR with full sweep of it should be readily merge-able. (Could you open an issue? It'll make a good first issue too) |
fairingrey
approved these changes
May 22, 2019
bIgBV
approved these changes
May 22, 2019
Nemo157
approved these changes
May 23, 2019
yoshuawuyts
reviewed
May 23, 2019
| @@ -16,7 +16,7 @@ impl std::fmt::Display for StringError { | |||
| #[macro_export] | |||
| macro_rules! err_fmt { | |||
| {$($t:tt)*} => { | |||
| crate::error::StringError(format!($($t)*)) | |||
| $crate::error::StringError(format!($($t)*)) | |||
There was a problem hiding this comment.
Hi @yoshuawuyts - yes! This is needed since err_fmt is in tide_core and also re-exported by tide.
yoshuawuyts
approved these changes
May 23, 2019
|
With 4 approvals, I'll go ahead and merge this 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
tidelib.rstide_core::internalMotivation and Context
#252, #162
How Has This Been Tested?
All tests passed
Types of changes
Checklist: