feat: if json Serialize failure return 500 #321
Closed
+70
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoshuawuyts
requested changes
Sep 5, 2019
tide-core/src/response.rs
Outdated
| .body(Body::from(v)), | ||
| Err(e) => res | ||
| .status(http::status::StatusCode::INTERNAL_SERVER_ERROR) | ||
| .body(Body::from(e.to_string())), |
There was a problem hiding this comment.
We probably shouldn't leak details to the client here; instead logging using log::error and returning an empty body seems like a better option (:
|
CI's network problem. |
|
Looks to me like the requested changes were made (I agree, we don't want to expose the reason serialization failed, by default). I'd like to see this merged into Any objections to rebasing on |
Updates the requirements on [env_logger](https://github.com/sebasmagri/env_logger) to permit the latest version. - [Release notes](https://github.com/sebasmagri/env_logger/releases) - [Changelog](https://github.com/sebasmagri/env_logger/blob/master/CHANGELOG.md) - [Commits](rust-cli/env_logger@v0.6.1...v0.7.0) Signed-off-by: dependabot-preview[bot] <[email protected]>
Updates the requirements on [juniper](https://github.com/graphql-rust/juniper) to permit the latest version. - [Release notes](https://github.com/graphql-rust/juniper/releases) - [Commits](graphql-rust/juniper@juniper-0.13.1...juniper-v0.14.0) Signed-off-by: dependabot-preview[bot] <[email protected]>
Updates the requirements on [uuid](https://github.com/uuid-rs/uuid) to permit the latest version. - [Release notes](https://github.com/uuid-rs/uuid/releases) - [Commits](https://github.com/uuid-rs/uuid/commits) Signed-off-by: dependabot-preview[bot] <[email protected]>
Resolve rustasync/http-rs#316
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If JSON Serialize failure return 500 and Error message.
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist: