Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dev dependency on the runtime crate #334

Merged
merged 1 commit into from
Oct 29, 2019
Merged

Remove dev dependency on the runtime crate #334

merged 1 commit into from
Oct 29, 2019
+0 −28

Conversation

secretfader
Copy link

Resolves #333 by removing the development dependency on runtime.

Nemo157
Nemo157 approved these changes Oct 29, 2019
View reviewed changes
Copy link
Contributor

@Nemo157 Nemo157 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a separate PR to add the http-service-hyper example would be great.

@secretfader
Copy link
Author

a separate PR to add the http-service-hyper example would be great.

I'll PR a new example shortly.

@secretfader secretfader merged commit dfbaf72 into http-rs:master Oct 29, 2019
@secretfader secretfader deleted the remove-devdep-runtime branch October 29, 2019 21:36
@yoshuawuyts yoshuawuyts mentioned this pull request Oct 31, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nemo157 Nemo157 Nemo157 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove example that relies on runtime crate
2 participants
@secretfader @Nemo157