Parse string values for add_special_tokens in vLLM #598
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to evaluate reasoning models on e.g. AIME task, we would run evals like this:
As part of
MODEL_ARGS
we would like to be able to specify value foradd_special_tokens
to control whether BOS token is added or not by tokenizer. At the moment this is not possible because the given value will be interpreted as string whereas the codebase relies on boolean. This PR enables this by parsingadd_special_tokens
like other vLLM params are parsed in theclass VLLMModel
.