-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Minimal Reproducible Usage Example For TPU support on examples/seq2seq #5960
Conversation
The test will obviously break, right? |
Any progress on merging this? |
they won't accept it as the checks have failed? |
Is that so @sshleifer? |
@@ -943,6 +943,7 @@ def __init__(self, config: BartConfig): | |||
super().__init__(config) | |||
base_model = BartModel(config) | |||
self.model = base_model | |||
self.lm_head = _make_linear_from_emb(self.model.shared) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need to call this again after line 952 to make the tests pass.
Thanks for the contribution, this looks awesome! We can't merge with failing tests, but I think the tests can pass. Could you also check
add the |
Actually can we add a |
I tried this version and it seems to work but it stucks at "Validation sanity check". Working colab here |
Well I removed the validation check altogether by passing in the concerned
flag to 0. Tried debugging to find out what's causing it, but I couldn't
figure it out.
If you will train and validate, it will work.
…On Mon, 27 Jul 2020, 17:46 marton-avrios, ***@***.***> wrote:
I tried this version and it seems to work but it stucks at "Validation
sanity check".
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#5960 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFNPJJQYIPQDG5ZPYXDTTT3R5VV23ANCNFSM4PEHWJYA>
.
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This is now supported by |
Attempt to resolve #5895.
Minimal Working Colab Example.
For using more than a single core, one needs to ensure that enough RAM is available else wait for PyTorch-XLA to release a stable version. They have also released a fix way back that prevent excessive memory usage for nightly.