Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(docs): update mockFunction API documentation #82

Merged
merged 4 commits into from
Apr 1, 2021
Merged

chore(docs): update mockFunction API documentation #82

merged 4 commits into from
Apr 1, 2021

Conversation

lkipke
Copy link
Contributor

@lkipke lkipke commented Mar 29, 2021

Closes #81

@lkipke lkipke added enhancement New feature or request documentation labels Mar 29, 2021
@lkipke lkipke requested review from sjbarag and alimnios72 March 29, 2021 21:22
@lkipke lkipke self-assigned this Mar 29, 2021
sjbarag
sjbarag suggested changes Mar 30, 2021
View reviewed changes
Copy link
Contributor

@sjbarag sjbarag left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a little copy-spaghetti spilled onto your keyboard here 😛

This'll be great once we get the docs for mock.mockReturnValue(value) fixed!

@lkipke lkipke force-pushed the update-mockFunction-docs branch from a923f72 to 965663c Compare March 30, 2021 23:20
lkipke
lkipke commented Mar 30, 2021
View reviewed changes
docs/guides/testing-functions.md
@@ -53,8 +53,8 @@ If `FooComponent` uses the `foo` function as a callback:
<!-- Field with a callback we want to test -->
<field id="myField" type="string" onChange="foo" />

<!-- Field with a callback we want to test -->
<field id="sideEffectField" type="string">
<!-- Field that gets modified as a side-effect of the `foo` function -->
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes a different copy-lasagna error from #85... turns out when i write documentation i need to be a little more careful 😅

@lkipke lkipke requested a review from sjbarag March 30, 2021 23:21
sjbarag
sjbarag approved these changes Apr 1, 2021
View reviewed changes
Copy link
Contributor

@sjbarag sjbarag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the copy-farfalle is all gone — thanks for the quick cleanup!

@lkipke lkipke merged commit 1f0ed24 into hulu:main Apr 1, 2021
@lkipke lkipke deleted the update-mockFunction-docs branch April 1, 2021 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjbarag sjbarag sjbarag approved these changes

@alimnios72 alimnios72 Awaiting requested review from alimnios72

Assignees

@lkipke lkipke

Labels
documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update mockFunction docs
2 participants
@lkipke @sjbarag