fix(runner): return correct exit code when something fails #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkipke
approved these changes
Apr 29, 2021
sjbarag
approved these changes
Apr 29, 2021
There was a problem hiding this comment.
Looks great! If we wanted to be super unix nerds we could make the return code be the number of failed tests, but I'm 10000% okay with just returning 1 😃
Excellent work @alimnios72 — thanks for jumping on this so fast!
yeah that's something we can try in the future, I wonder if the CI/CD gets any benefit if having exit codes different than |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
forbid-focusedoption is passed and there is at least one focused testfixes #94