Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new
CorsError
class to handle CORS-related errors more effectively and updates various parts of the codebase to use this new error class. The most important changes involve refactoring existing error handling to useCorsError
and updating tests accordingly. This ensures that CORS errors all follow the same uniform messaging.Introduction of
CorsError
class:src/cors.js
: Added theCorsError
class to represent errors that occur when a CORS request is blocked.Refactoring error handling to use
CorsError
:src/cors.js
: Updated theassertCorsResponse
function and methods in theCorsPreflightData
class to throwCorsError
instead ofError
. [1] [2] [3] [4]Updates to dependent modules:
src/fetch-mocker.js
: ImportedCorsError
and updated theFetchMocker
class to use the new error class in preflight validation and error handling. [1] [2] [3]Updates to tests:
tests/fetch-mocker.test.js
: Updated tests to expectCorsError
instead ofError
and adjusted error messages to match the new format. [1] [2] [3] [4] [5]