fix: Make Mentoss work in Bun #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements changes to make Mentoss work in Bun. To do so, I had to workaround a couple of bugs that are present in Bun's
fetchimplementation:oven-sh/bun#17052
oven-sh/bun#17085
Improvements to fetch requests:
src/fetch-mocker.js: Added a workaround to handle Bun's fetch implementation that sets credentials to "include" by default and doesn't allow overwriting that value when creating a Request.Improvements to tests:
tests/fetch-mocker.test.js: Simplified the error message assertion in theFetchMockertest to use a regular expression instead of an object.tests/mock-server.test.js: Set the default content type to "text/plain;charset=UTF-8" for non-JSON request bodies in thecreateRequestfunction.