Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add gripper support #24

Closed
wants to merge 2 commits into from
Closed

Conversation

k-okada
Copy link
Contributor

@k-okada k-okada commented Jan 18, 2016

modified/cleanuped version of #23, this requires husky/husky#22

@@ -53,6 +55,12 @@ ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSI
<!-- Stow the arm -->
<node pkg="husky_control" type="stow_ur5" name="stow_ur5"/>

<!-- Start the pr2 gripper controller and action server -->
<group if="$(arg gripper_enabled)">
<rosparam command="load" file="$(find husky_control)/config/control_gripper.yaml" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not seeing this file anywhere

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

forget to add see husky/husky#22

<rosparam command="load" file="$(find husky_control)/config/control_gripper.yaml" />
<node name="r_gripper_controller_spawner" pkg="controller_manager" type="spawner" args="r_gripper_controller"/>
<!-- https://github.com/ros-controls/ros_controllers/pull/181 -->
<node name="r_gripper_state_publisher" pkg="rostopic" type="rostopic"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this necessary? Are these joints not controlled?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to publish joint_states for non actuated joints for moveit

◉ Kei Okada

On Tue, Jan 19, 2016 at 11:23 PM, Paul Bovbel [email protected]
wrote:

In husky_gazebo/launch/spawn_husky.launch
#24 (comment):

@@ -53,6 +55,17 @@ ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSI

  •    <rosparam command="load" file="$(find husky_control)/config/control_gripper.yaml" />
    
  •    <node name="r_gripper_controller_spawner" pkg="controller_manager" type="spawner" args="r_gripper_controller"/>
    
  •    <!-- https://github.com/ros-controls/ros_controllers/pull/181 -->
    
  •    <node name="r_gripper_state_publisher" pkg="rostopic" type="rostopic"
    

Why is this necessary? Are these joints not controlled?


Reply to this email directly or view it on GitHub
https://github.com/husky/husky_simulator/pull/24/files#r50116885.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood, but does r_gripper_controller not control anything other than r_gripper_l_finger_joint? Are these joints just floating, or is there a mechanism to keep them rigid?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sending command to r_gripper_controller change all joint in the gripper.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood, so then why is this necessary? Shouldn't the joint state controller publish the states for any controller joints?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure, but maybe there is not transmission for gripper joints

◉ Kei Okada

On Fri, Jan 22, 2016 at 1:02 AM, Paul Bovbel [email protected]
wrote:

In husky_gazebo/launch/spawn_husky.launch
#24 (comment):

@@ -53,6 +55,17 @@ ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSI

  •    <rosparam command="load" file="$(find husky_control)/config/control_gripper.yaml" />
    
  •    <node name="r_gripper_controller_spawner" pkg="controller_manager" type="spawner" args="r_gripper_controller"/>
    
  •    <!-- https://github.com/ros-controls/ros_controllers/pull/181 -->
    
  •    <node name="r_gripper_state_publisher" pkg="rostopic" type="rostopic"
    

Understood, so then why is this necessary? Shouldn't the joint state
controller publish the states for any controller joints?


Reply to this email directly or view it on GitHub
https://github.com/husky/husky_simulator/pull/24/files#r50420034.

@tonybaltovski
Copy link
Member

Closing to due inactivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants