You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is an excellent library -- thank you for writing it. How would you feel about returning the result of dispatch to callers? If the event is cancelable and at least one handler invokes preventDefault(), the return value of dispatchEvent will be false, which could be important to know.
If you think this is a good idea but don't have time to work on it, let me know and I'll create a PR with the code change, updated README documentation, and unit tests.
The text was updated successfully, but these errors were encountered:
Thank you for comment about the library - it is very encouraging to do more :) Actually, I never have used returned value of dispatchEvent, so I have to say I didn't notice, that it returns something meaningful.
For the change, is up to you, it is a trivial, but maybe you want to have your first commit, so your welcome to create PR :) If not, I will push it.
Yesterday I found a bug related to invalidation propagation, which is already pushed. I will release a new version today, so I will push a change with dispatchEvent as well. You don't have to create PR.
This is an excellent library -- thank you for writing it. How would you feel about returning the result of
dispatch
to callers? If the event is cancelable and at least one handler invokes preventDefault(), the return value of dispatchEvent will befalse
, which could be important to know.hybrids/src/utils.js
Lines 10 to 11 in 743caeb
If you think this is a good idea but don't have time to work on it, let me know and I'll create a PR with the code change, updated README documentation, and unit tests.
The text was updated successfully, but these errors were encountered: