-
Notifications
You must be signed in to change notification settings - Fork 87
fix: add force option to invalidate callback #167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f25790a:
|
Hi @bennypowers! Look promising, It might help binding with external libraries. I like idea to mix up arguments of Are you willing to do that, or should I merge your PR to the working branch and continue changes? |
I'll give it a shot just now, I've got the repo up and running locally. I have to step out in a few hours, so I'll push what I have at that time and ping you on gitter. Thanks for the review! |
@smalluban latest commit combines options into a single object. I only documented the |
Side note: this options object could be expanded in the future, e.g. a |
I implemented those suggestions but test fail now, can you take a look? |
Fixes #166