-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial implementation of plugin architecture. #26
Initial implementation of plugin architecture. #26
Conversation
Signed-off-by: KoleBarnes <[email protected]>
Signed-off-by: KoleBarnes <[email protected]>
Signed-off-by: KoleBarnes <[email protected]>
Signed-off-by: KoleBarnes <[email protected]>
Signed-off-by: KoleBarnes <[email protected]>
Brilliant! Thank you @WadeBarnes and @KoleBarnes. This is a massive improvement. |
A note for @swcurran. This is the initial framework. The additional automated node monitoring plugin(s) that are in development will be added once this is merged. |
It's all @KoleBarnes, I'm just providing support and a little guidance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!! Nice work. I've not had a chance to run these, so am not marking approved yet (although others can), but I really like this approach. Even better than the bash pipeline way :-)
Signed-off-by: Wade Barnes <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been using this heavily over the last few days while troubleshooting a few nodes on Sorin StagingNet. The only issue I discovered was one that existed in my original code.
Including documentation.