Skip to content

Initial build/publish system for docker image artifact #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 14, 2021
Merged

Initial build/publish system for docker image artifact #269

merged 2 commits into from
May 14, 2021

Conversation

darkn3rd
Copy link
Contributor

@darkn3rd darkn3rd commented May 14, 2021 •
edited
Loading

The following features are added:

  • makefile to build and push ratel docker image
  • fixed issue with Dockerfile
  • added package manifest in a separate docker image layer (best practices)
  • added go-bindata install as separate docker image layer (best practices)
  • run service in as unprivileged user dgraph (best practices)

None Goals:

  • testing component is not updated; this needs to be updated, as it utilizes dgraph/dgraph:master image
  • publishing binary artifacts not addressed in this release (currently manual process)

This change is Reviewable

@darkn3rd darkn3rd merged commit 64bd6e8 into master May 14, 2021
@darkn3rd darkn3rd deleted the joaquin/makefile branch May 14, 2021 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichelDiz MichelDiz MichelDiz approved these changes

@tstreamDOTh tstreamDOTh Awaiting requested review from tstreamDOTh

@chewxy chewxy Awaiting requested review from chewxy

@danielmai danielmai Awaiting requested review from danielmai

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@darkn3rd @MichelDiz