Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DummyValue must use default_value if present #192

Closed
catmando opened this issue May 20, 2019 · 0 comments
Closed

DummyValue must use default_value if present #192

catmando opened this issue May 20, 2019 · 0 comments
Labels
bug Something isn't working ready-to-release Internal Use Only: Has been fixed, specs passing and pushed to edge branch
Milestone
alpha1.5

Comments

@catmando
Copy link
Contributor

currently DummyValue will ignore the default_value of the columns_hash if the default_value is nil. For example if the column is a string type, and the default_value is nil, then the DummyValue will be the empty string instead of nil.

This causes problems especially for Serialized values because empty string is not acceptable to rails (but nil is)
@catmando catmando added the bug Something isn't working label May 20, 2019
@catmando catmando added this to the alpha1.5 milestone May 20, 2019
catmando added a commit that referenced this issue May 22, 2019
@catmando
fixes regression from #192 and adds specs
23c2dd6
@catmando catmando added the ready-to-release Internal Use Only: Has been fixed, specs passing and pushed to edge branch label Jun 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working ready-to-release Internal Use Only: Has been fixed, specs passing and pushed to edge branch
Projects
None yet
Milestone
alpha1.5
Development

No branches or pull requests
1 participant
@catmando