Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regex isn't working for GCP #93

Closed
liaodaniel opened this issue Feb 26, 2025 · 2 comments
Closed

Regex isn't working for GCP #93

liaodaniel opened this issue Feb 26, 2025 · 2 comments

Comments

@liaodaniel
Copy link

The regex at

proxy.OnRequest(goproxy.ReqHostMatches(regexp.MustCompile(`^(?:.*\.amazonaws\.com(?:\.cn)?)|(?:management\.azure\.com)|(?:management\.core\.windows\.net)|(?:.*\.googleapis\.com)$`))).HandleConnect(goproxy.AlwaysMitm)
seems to failing with the gcp provider. From my initial investigation, the proxy works as expected with the $ removed from the regex on both gcloud and terraform CLI. I can't really explain the why but I am running this from macOS Sequoia if that helps.

@iann0036
Copy link
Owner

Hi @liaodaniel,

Thanks for raising. I...also don't understand why that regex rule isn't working correctly, but happy to implement the fix as you suggest.

Releasing this as v1.1.22, let me know if that works better for you.

@liaodaniel
Copy link
Author

v1.1.22 is working. Thanks again!

tmeijn pushed a commit to tmeijn/dotfiles that referenced this issue Feb 27, 2025
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [iann0036/iamlive](https://github.com/iann0036/iamlive) | patch | `v1.1.21` -> `v1.1.22` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>iann0036/iamlive (iann0036/iamlive)</summary>

### [`v1.1.22`](https://github.com/iann0036/iamlive/releases/tag/v1.1.22)

[Compare Source](iann0036/iamlive@v1.1.21...v1.1.22)

#### Changelog

-   [`938dc39`](iann0036/iamlive@938dc39) Fix regex issue for proxy connections [#&#8203;93](iann0036/iamlive#93)
-   [`25128d1`](iann0036/iamlive@25128d1) Merge pull request [#&#8203;92](iann0036/iamlive#92) from boyter/main
-   [`337c229`](iann0036/iamlive@337c229) add ignore file for vendor for better rg support

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xODEuMCIsInVwZGF0ZWRJblZlciI6IjM5LjE4MS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants