move loom to dev-dependencies #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think works. I want loom to be enabled in integration tests, and for other crates that use loom and have boxcar as a dependency, so it can't just be a dev-dep. To avoid the lockfile issue maybe we can make it optional like crossbeam instead? |
conradludgate
force-pushed
the
remove-loom-dependency
branch
from
d1ad99b to
70221fa
Compare
|
Looks good, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding boxcar to my dependencies has massively inflated my lockfile with the current setup.
Moving loom to dev-deps is how tokio handles loom.