Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Changed images from jpg/png to webp #2360

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Sriram-7451
Copy link

PR is raised for the resolve for the issue #2357

Changed the Images from JPG/PNG to WebP

Conversion was done through conversion tool available in the internet and was able to reduce the asset storage.

Copy link

welcome bot commented Mar 15, 2025

Thank you for opening this pull request with us! Be sure to follow our Pull Request Practices. Let us know if you have any questions on Slack.

@julianguyen
Copy link
Member

Ooh so exciting, thanks for the fast follow!

I would keep our favicon image as an .ico file. I think it can be in .webp but not all browsers may support it. So you can at an HTML tag in our header for the .webp version but also keep the current .ico version.

@Sriram-7451
Copy link
Author

@julianguyen Added both images actually ico and webp for favicon in header

@julianguyen
Copy link
Member

Looks like there's remaining updates that need to be made:

/home/circleci/ifmeorg/ifme/client/app/stories/Avatar.stories.jsx
  5:19  error  Unable to resolve path to module 'app/assets/images/contributors/ingrid_garcia.jpg'  import/no-unresolved

/home/circleci/ifmeorg/ifme/client/app/stories/Modal.stories.jsx
  5:19  error  Unable to resolve path to module 'app/assets/images/contributors/ingrid_garcia.jpg'  import/no-unresolved

@julianguyen julianguyen self-requested a review March 23, 2025 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants