New homepage #1
Merged
New homepage #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
genevievehelsel
requested changes
Feb 26, 2018
pages/index.js
Outdated
| } | ||
|
|
||
| deleteQueue(courseId, queueId) { | ||
| this.props.deleteQueue(courseId, queueId) |
There was a problem hiding this comment.
is it possible to have this pop up a modal (similar to components/ConfirmLeaveQueueModal.js ) in order to help prevent accidental deletion?
There was a problem hiding this comment.
yep - that was already on my todo list for another PR, but that makes sense to do here.
genevievehelsel
approved these changes
Feb 27, 2018
This was referenced Feb 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to make the homepage a bit friendlier and useful
Things that still have to be done: