Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Don't merge yet] Update glob dependency #119

Closed
wants to merge 1 commit into from

Conversation

HeroicKatora
Copy link
Member

Tries to fix the tests under minimal-versions in the Travis matrix. Some dependency
resolves to winapi=0.0.1 in that condition and this is a faulty version that was not
yanked. The guess here is that getopts is affected since it did depend on tempdir
but now that has been relegated to a dev-dependency. We'll see.

@HeroicKatora
Copy link
Member Author

HeroicKatora commented Apr 28, 2019

No, it is in fact advapi32-sys v0.1.2 which declares:

  • winapi = *

Now, to find out which package depends on advapi32-sys

@fintelia
Copy link
Contributor

I recommend giving cargo tree a try for tracking down issues like this

@HeroicKatora
Copy link
Member Author

Yes, but I need to track down what happens on Travis... And can't reproduce it locally 😬

@HeroicKatora
Copy link
Member Author

HeroicKatora commented Apr 28, 2019

Oh god, it is in fact

  • term = 0.4 (possibly more) which depends on
  • winapi = 0.2.4 which depends on
  • advapi32-sys = * which depends on
  • winapi = *

@HeroicKatora
Copy link
Member Author

So, effectively I should have read about minimal-versions in cargo before this since rust-lang/cargo#5757 has the same problem ^^

@HeroicKatora
Copy link
Member Author

HeroicKatora commented Apr 28, 2019

  • The dev-dependency glium = 0.22 depends on
  • glutin = ^0.17 depends on
  • wayland_client = 0.20.12 depends on
  • wayland-sys = 0.20.7 depends on
  • dlib = ^0.4 depends on
  • libloading = ^0.4.0 also depends on
  • winapi = ^0.2

This fixes a dependency resolution problem when picking minimal
dependencies as allowed by SemVer. The underlying problem is with the
outdated `winapi = ^0.2`, which contains a chain to `advapi32-sys = *`
and finally `winapi = 0.0.1`, which is itself a faulty package (invalid
syntax). In the glium case, the dependency chain is much longer through
`glutin`, wayland, `dlib` and `libloading`.
@HeroicKatora
Copy link
Member Author

   Compiling lazy_static v0.1.0
     Running `rustc --crate-name lazy_static /home/travis/.cargo/registry/src/github.lhy31512.workers.dev-1ecc6299db9ec823/lazy_static-0.1.0/src/lazy_static.rs --color always --crate-type lib --emit=dep-info,link -C debuginfo=2 -C metadata=b92219cd1010870c -C extra-filename=-b92219cd1010870c --out-dir /home/travis/build/image-rs/image-png/target/debug/deps -L dependency=/home/travis/build/image-rs/image-png/target/debug/deps --cap-lints allow`
error[E0658]: non-builtin inner attributes are unstable
  --> /home/travis/.cargo/registry/src/github.lhy31512.workers.dev-1ecc6299db9ec823/lazy_static-0.1.0/src/lazy_static.rs:74:1
   |
74 | #![license = "MIT"]
   | ^^^^^^^^^^^^^^^^^^^
   |
   = note: for more information, see https://github.com/rust-lang/rust/issues/54726
   = help: add #![feature(custom_inner_attributes)] to the crate attributes to enable

Oh no

@HeroicKatora
Copy link
Member Author

HeroicKatora commented Apr 28, 2019

There is nothing we can directly do, I fear:

  • glium = 0.24 (newest) depends on
  • glutin = ^0.20 depends on
  • shared_library = ^0.1.0 depends on
  • lazy_static = ^0.1 which fails

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants