Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: upgrade to Eleventy v3 and friends #1169

Merged
merged 33 commits into from
Feb 26, 2025
Merged

feat!: upgrade to Eleventy v3 and friends #1169

merged 33 commits into from
Feb 26, 2025

Conversation

greatislander
Copy link
Member

@greatislander greatislander commented Feb 25, 2025

  • This pull request has been tested by running npm run test without errors
  • This pull request has been built by running npm run build without errors
  • This isn't a duplicate of an existing pull request

Description

Upgrades to Eleventy v3, removing or replacing deprecated plugins. Also switches from Sass to CSS as we are coming up on Sass deprecating @import which would require a major refactor.

Steps to test

  1. Review deployment preview.

Expected behavior: Site looks and behaves as expected.

Additional information

Depends on #1167.

Related issues

See: 11ty/eleventy#3665

@greatislander greatislander requested a review from jobara February 25, 2025 19:33
@greatislander greatislander self-assigned this Feb 25, 2025
Copy link

netlify bot commented Feb 25, 2025

Deploy Preview for idrc ready!

Name Link
🔨 Latest commit 04cdc06
🔍 Latest deploy log https://app.netlify.com/sites/idrc/deploys/67bf3ba8c9ce5a0008b8444e
😎 Deploy Preview https://deploy-preview-1169--idrc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cloudflare-workers-and-pages bot commented Feb 25, 2025

Deploying idrc-ocadu-ca with  Cloudflare Pages  Cloudflare Pages

Latest commit: 04cdc06
Status: ✅  Deploy successful!
Preview URL: https://a516bae0.idrc-ocadu-ca.pages.dev
Branch Preview URL: https://feat-eleventy-v3.idrc-ocadu-ca.pages.dev

View logs

@jobara
Copy link
Member

jobara commented Feb 25, 2025

@greatislander not sure if this is related to the linked issue, but it seems on the project page there are no links to the project pages that are in the IDRC site, only external links are present. Also there's a failure on the Lighthouse Audit, it can't find the URL.

@jobara
Copy link
Member

jobara commented Feb 26, 2025

@greatislander there seems to be an issue with the funder logos. This is from the bottom of the Financial Inclusion page.

Screenshot of funder logos not rendering properly on the Financial Inclusion page

There might be issues with other images as well. See the Future of Work page too.

@greatislander greatislander added enhancement New feature or request dependencies Pull requests that update a dependency file labels Feb 26, 2025
@greatislander greatislander added this to the 3.0.0 milestone Feb 26, 2025
@jobara
Copy link
Member

jobara commented Feb 26, 2025

@greatislander I notice that the order of the project on the projects page is different from the current live site. Is that intentional?

@greatislander greatislander enabled auto-merge (squash) February 26, 2025 15:38
@greatislander greatislander requested a review from jobara February 26, 2025 15:52
@greatislander greatislander merged commit b489d10 into dev Feb 26, 2025
10 checks passed
@greatislander greatislander deleted the feat/eleventy-v3 branch February 26, 2025 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants