-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: upgrade to Eleventy v3 and friends #1169
Conversation
Signed-off-by: Ned Zimmerman <[email protected]>
ci: point Lighthouse workflow to Cloudflare Signed-off-by: Ned Zimmerman <[email protected]>
Signed-off-by: Ned Zimmerman <[email protected]>
feat: replace imagePositionWithText shortcode Signed-off-by: Ned Zimmerman <[email protected]>
✅ Deploy Preview for idrc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Deploying idrc-ocadu-ca with
|
Latest commit: |
04cdc06
|
Status: | ✅ Deploy successful! |
Preview URL: | https://a516bae0.idrc-ocadu-ca.pages.dev |
Branch Preview URL: | https://feat-eleventy-v3.idrc-ocadu-ca.pages.dev |
Signed-off-by: Ned Zimmerman <[email protected]>
@greatislander not sure if this is related to the linked issue, but it seems on the project page there are no links to the project pages that are in the IDRC site, only external links are present. Also there's a failure on the Lighthouse Audit, it can't find the URL. |
@greatislander there seems to be an issue with the funder logos. This is from the bottom of the Financial Inclusion page. ![]() There might be issues with other images as well. See the Future of Work page too. |
@greatislander I notice that the order of the project on the projects page is different from the current live site. Is that intentional? |
npm run test
without errorsnpm run build
without errorsDescription
Upgrades to Eleventy v3, removing or replacing deprecated plugins. Also switches from Sass to CSS as we are coming up on Sass deprecating
@import
which would require a major refactor.Steps to test
Expected behavior: Site looks and behaves as expected.
Additional information
Depends on #1167.
Related issues
See: 11ty/eleventy#3665