feat!: upgrade to Eleventy v3 and friends #1169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ned Zimmerman <[email protected]>
ci: point Lighthouse workflow to Cloudflare Signed-off-by: Ned Zimmerman <[email protected]>
Signed-off-by: Ned Zimmerman <[email protected]>
feat: replace imagePositionWithText shortcode Signed-off-by: Ned Zimmerman <[email protected]>
✅ Deploy Preview for idrc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Deploying idrc-ocadu-ca with
|
| Latest commit: |
04cdc06
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a516bae0.idrc-ocadu-ca.pages.dev |
| Branch Preview URL: | https://feat-eleventy-v3.idrc-ocadu-ca.pages.dev |
Signed-off-by: Ned Zimmerman <[email protected]>
|
@greatislander not sure if this is related to the linked issue, but it seems on the project page there are no links to the project pages that are in the IDRC site, only external links are present. Also there's a failure on the Lighthouse Audit, it can't find the URL. |
|
@greatislander there seems to be an issue with the funder logos. This is from the bottom of the Financial Inclusion page. 
There might be issues with other images as well. See the Future of Work page too. |
greatislander
added
enhancement
|
@greatislander I notice that the order of the project on the projects page is different from the current live site. Is that intentional? |
jobara
reviewed
Feb 26, 2025
jobara
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm run testwithout errorsnpm run buildwithout errorsDescription
Upgrades to Eleventy v3, removing or replacing deprecated plugins. Also switches from Sass to CSS as we are coming up on Sass deprecating
@importwhich would require a major refactor.Steps to test
Expected behavior: Site looks and behaves as expected.
Additional information
Depends on #1167.
Related issues
See: 11ty/eleventy#3665