Added TryIntoJs for Options #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simlay
force-pushed
the
try-into-js-for-option-t
branch
from
7ff0255 to
8f40ff6
Compare
|
@sehz Thoughts? |
sehz
requested changes
Dec 29, 2020
Closed
|
In #33, None returns undefined but I agree as in this PR, it should return null |
simlay
force-pushed
the
try-into-js-for-option-t
branch
from
8f40ff6 to
5df0677
Compare
* Updated CHANGLOG.md
simlay
force-pushed
the
try-into-js-for-option-t
branch
from
5df0677 to
382859b
Compare
Done. I also updated the formatting on the headers. Here's the |
|
Great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want this in some stuff for fluvio-client-node.