-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Biconsumer exception callback #319
Biconsumer exception callback #319
Conversation
c2139fd
to
bb394f2
Compare
Codecov Report
@@ Coverage Diff @@
## master #319 +/- ##
============================================
+ Coverage 79.04% 79.66% +0.62%
- Complexity 135 137 +2
============================================
Files 11 11
Lines 711 723 +12
Branches 77 78 +1
============================================
+ Hits 562 576 +14
+ Misses 107 106 -1
+ Partials 42 41 -1
Continue to review full report at Codecov.
|
Great thanks, i like it. |
Cool, I've fixed the readme, I think this is ready to be merged. |
One missing nit: Changelog entry |
Thanks! It would be nice if you could release a snapshot version so we can
start using the new feature. Is that possible?
Em qui, 11 de mai de 2017 13:29, Stefan Majer <[email protected]>
escreveu:
… Merged #319 <#319>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#319 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA9JDrX5FkMpQr0oif3OollL61j4iLgnks5r4vEfgaJpZM4NXyfP>
.
|
I will trigger the people from influxdata because they are only able to push to maven central. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
@majst01 were the influxdata guys able to release the snapshot? |
I am in contact with them, please be patient. |
@majst01 any updates on that? sorry, I don't want to be a pusher but it's been two weeks already :) If you think it will still take long I'll ship a local jar in our application, just let me know. |
Im still waiting for the influxdb guys to push to maven central. i will ask again. sorry |
Has there been any progress on getting a release for this feature? |
it is released ! |
Alternative implementation of #318