refactor: deprecate tx & bundle polling tasks #22
Conversation
anna-carroll
requested review from
Evalir,
prestwich and
dylanlott
as code owners
anna-carroll
force-pushed
the
anna/delete-server
branch
from
594a8ca to
1803974
Compare
anna-carroll
force-pushed
the
anna/rm-poll-tasks
branch
from
e38801f to
a213722
Compare
src/tasks/block.rs
Outdated
| select! { | ||
| biased; | ||
| _ = &mut sleep => { | ||
| // Build a block | ||
| let mut in_progress = InProgressBlock::default(); | ||
| self.get_transactions(&mut in_progress).await; | ||
| self.get_bundles(&mut in_progress).await; | ||
|
|
||
| if !in_progress.is_empty() { |
There was a problem hiding this comment.
So, as far as I understand now, instead of spawning a loop that awaits 3 different futures concurrently, we now have a loop that:
- gets all txs
- gets all bundles
- builds the block
- sends it
- sleeps for X seconds
In this case we don't need the select! at all anymore. We just need to loop like we already are and go through the steps.
There was a problem hiding this comment.
good shout ada0cd2
anna-carroll
force-pushed
the
anna/rm-poll-tasks
branch
from
ada0cd2 to
4fde3cc
Compare
| self.get_bundles(&mut in_progress).await; | ||
|
|
||
| // submit the block if it has transactions | ||
| if !in_progress.is_empty() { |
There was a problem hiding this comment.
should we maybe log if we find there are no txs?
There was a problem hiding this comment.
i have this in next PR :)
| self.get_transactions(&mut in_progress).await; | ||
| self.get_bundles(&mut in_progress).await; |
There was a problem hiding this comment.
an interesting byproduct of this is that bundles will land end of block. nothing to do here now, but something we might wanna think about later
There was a problem hiding this comment.
yes i think any logic around ordering could be layered in later
No description provided.