fix: update builder loop to wake up at target block time #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anna-carroll
requested review from
Evalir,
prestwich and
dylanlott
as code owners
anna-carroll
force-pushed
the
anna/update-builder-loop
branch
from
595cc8b to
be716b1
Compare
Evalir
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR makes the sleep time “block-slot-aware”
it targets a configurable interval within the block slot at which it begins building a new block
previously, sleeping a fixed buffer amount will cause the builder to attempt to submit blocks at random times relative to the chain’s block slot time; e.g. it could be attempting to submit 1sec before the slot ends, in which case the submission will almost certainly fail