Skip to content
This repository was archived by the owner on Mar 26, 2025. It is now read-only.

chore: Adds ZenithEthBundle type to bundle module #71

Merged
merged 1 commit into from
Jan 8, 2025
Merged

chore: Adds ZenithEthBundle type to bundle module #71

merged 1 commit into from
Jan 8, 2025

Conversation

dylanlott
Copy link
Contributor

@dylanlott dylanlott commented Jan 7, 2025 •
edited
Loading

TL;DR

  • Adds SignetEthBundle type from signet-node into the bundle module and renames it to Zenith prefixed naming
  • Exposes bundle module for external use

@dylanlott Graphite App
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@dylanlott dylanlott force-pushed the 01-07-adds_signetethbundle_type_to_remove_signet-node_dependency branch from 0c970ad to bff62db Compare January 7, 2025 18:12
dylanlott
dylanlott commented Jan 7, 2025
View reviewed changes
@dylanlott dylanlott changed the title adds SignetEthBundle type to remove signet-node dependency adds SignetEthBundle type to bundle module Jan 7, 2025
@dylanlott dylanlott marked this pull request as ready for review January 7, 2025 18:16
@dylanlott dylanlott requested a review from Evalir January 7, 2025 18:16
@dylanlott dylanlott self-assigned this Jan 7, 2025
Evalir
Evalir suggested changes Jan 7, 2025
View reviewed changes
Copy link
Member

@Evalir Evalir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also move all the other types of Bundles we have (the Call variants and such)

@dylanlott dylanlott requested a review from Evalir January 7, 2025 18:59
@Evalir Evalir changed the title adds SignetEthBundle type to bundle module adds ZenithEthBundle type to bundle module Jan 7, 2025
Evalir
Evalir suggested changes Jan 7, 2025
View reviewed changes
@dylanlott dylanlott changed the title adds ZenithEthBundle type to bundle module chore: Adds ZenithEthBundle type to bundle module Jan 8, 2025
graphite-app[bot]
graphite-app bot reviewed Jan 8, 2025
View reviewed changes
Evalir
Evalir approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@Evalir Evalir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!

@Evalir Evalir enabled auto-merge (squash) January 8, 2025 12:27
graphite-app[bot]
graphite-app bot reviewed Jan 8, 2025
View reviewed changes
@Evalir Evalir force-pushed the 01-07-adds_signetethbundle_type_to_remove_signet-node_dependency branch from 6c2b42e to 45a427e Compare January 8, 2025 12:28
@Evalir Evalir force-pushed the 01-07-adds_signetethbundle_type_to_remove_signet-node_dependency branch from 45a427e to 2c1f4f4 Compare January 8, 2025 12:41
@Evalir Evalir merged commit 6f62b9d into main Jan 8, 2025
5 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@graphite-app graphite-app[bot] graphite-app[bot] left review comments

@Evalir Evalir Evalir approved these changes

Assignees

@dylanlott dylanlott

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dylanlott @Evalir