feat: replace sequence and confirmBy with hostBlockNumber #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anna-carroll
commented
Jun 28, 2024
anna-carroll
commented
Jun 28, 2024
.gas-snapshot
Outdated
| ZenithTest:test_notSequencer() (gas: 34145) | ||
| ZenithTest:test_onePerBlock() (gas: 68700) | ||
| ZenithTest:test_submitBlock() (gas: 61119) |
There was a problem hiding this comment.
very nice reduction in gas costs
prestwich
reviewed
Jun 29, 2024
prestwich
reviewed
Jun 29, 2024
prestwich
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linear ticket
Motivation
The node will mine one RU block per host block.
Solution
As such, we can remove the
sequencenumber (that tracks the rollup block number and ensures blocks are mined in correct order) and theconfirmByfield (that ensures blocks are mined by a certain time).We can replace these fields with a
hostBlockNumberfield (that ensures that the rollup block is mined in the exact specified host block, encapsulating block ordering, block numbers, and expiration times within one field).As a convenience, we will also store the
deployBlockNumber- the host block number at which the contract was deployed. Rollup block numbers can be derived from this value.