feat: update fill logic #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anna-carroll
force-pushed
the
anna/final-fill
branch
from
04fa345 to
c986aa5
Compare
prestwich
reviewed
Jul 2, 2024
| /// The user calls `initiate` on a rollup; the Builder calls `fill` on the target chain aggregating Outputs. | ||
| /// @param outputs - The Outputs to be transferred. | ||
| /// @dev NOTE that here, Output.chainId denotes the *origin* chainId. | ||
| /// @custom:emits Filled |
There was a problem hiding this comment.
should note the caller is allowed to collapse outputs if the chain Id, recipient, and token are the same (by adding the value together)
prestwich
reviewed
Jul 2, 2024
| for (uint256 i; i < outputs.length; i++) { | ||
| if (outputs[i].token == address(0)) { | ||
| // this line should underflow if there's an attempt to spend more ETH than is attached to the transaction | ||
| value -= outputs[i].amount; |
There was a problem hiding this comment.
opt: future versions could crawl the list and collapse transfers to the same account, instead of having 1 transfer per output
There was a problem hiding this comment.
yeah, the Solidity for this is a bit gnarly though :) the Builder should aggregate the Outputs offchain to save on gas.
There was a problem hiding this comment.
builder can't aggregate outputs with different chain ids tho
prestwich
approved these changes
Jul 2, 2024
Merged
anna-carroll
force-pushed
the
anna/final-fill
branch
from
5a87474 to
b66fa9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
supersedes #53