This repository was archived by the owner on Apr 16, 2019. It is now read-only.
avoid neverending spinning wheel ui mask, when operation is stalled #897
+11
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imaffett
pushed a commit
that referenced
this pull request
Oct 20, 2015
avoid neverending spinning wheel ui mask, when operation is stalled
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes the loading mask (spinning wheel) can stay forever on screen, if some long network operation for instance is stalled, since the code to hide the mask may never be called. This is really annoying from the user perspective as the app becomes basically unusable as we cannot get rid of it.
An easy way to avoid this is having a default timeout when we show the ui mask...and by controlling the status of the ui mask (showing or hidden) we can guarantee that we always hide it.