Skip to content
This repository was archived by the owner on Apr 16, 2019. It is now read-only.

Fix panel active not remove between views and GoBack failure between different view. #901

Merged
merged 1 commit into from
Nov 3, 2015

Conversation

ArcRain
Copy link
Contributor

@ArcRain ArcRain commented Nov 3, 2015

1)Fix issues #850 #866 #873;
2)Fix explorer GoBack failed between different view;
3)Fix back button appended by code is invalid when 'click' on some device;
4)Add parameter 'back' to indicate whether transition is back in event 'panelunload' and 'panelload';
5)Code review for run 'grunt'

Major fixed issue is about panel active status between different views. Test case can use appframework DEMO. When loginview is modal, activated panel in 'mainview' is still active. After patching my code, the activated panel is remove.
For 'back' in event 'panelunload' and 'panelload', we can know whether transition is back.

2)Fix explorer GoBack failed between different view;
3)For event 'panelunload' and 'panelload', add parameter 'back' to indicate whether transition is back
4)Fix back button appended by code is invalid when 'click' on some device;
5)Code review for run 'grunt'
@imaffett
Copy link
Contributor

imaffett commented Nov 3, 2015

Thanks for the commit. I will review this today.

@imaffett
Copy link
Contributor

imaffett commented Nov 3, 2015

We now have an issue with the slide up transition. Since you remove active class on it, the content is white as the panel slides up. To test this, open up the kitchen sink app and click touch events. The content view content is hidden, but the header is still available.

@imaffett
Copy link
Contributor

imaffett commented Nov 3, 2015

https://github.com/01org/appframework/tree/ArcRain-master

I pushed a fix up there for the slide up transition. Can you please check it out?

@ArcRain
Copy link
Contributor Author

ArcRain commented Nov 3, 2015

OK. I'll check it out and test again.

@ArcRain
Copy link
Contributor Author

ArcRain commented Nov 3, 2015

I have checked it your fixed version out. Before I replaced changed files, I noticed that the content is white while doing slide up transition. With your fixed version, the issue has gone.
And I also checked my web app project with your fixed version. It works perfectly as I expect.
Thanks for your time and fixing up.

@imaffett imaffett merged commit 49316a8 into intel:master Nov 3, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants