[TGL] Disable E2E Compression for HW revisions 0 to 2 #1031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
E2E compression is currently disabled for HW revision 0. See [1]. The kernel commit in [2] indicates that media decompression is not available for steppings A0-C0. If we test the latest iHD with the latest drm-tip on a B-stepping, for example, we would see corrupted video frames on the display by default. This commit fixes this default behavior by disabling E2E compression until media decompression is available. This fixes intel#1029. [1] https://github.com/intel/media-driver/blob/d457d66da7065e5116f818e4bca2d6ea4b841422/media_driver/linux/gen12/ddi/media_sku_wa_g12.cpp#L257 [2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=dbff5a8db9c630f61a892ab41a283445e01270f5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
E2E compression is currently disabled for HW revision 0. See [1].
The kernel commit in [2] indicates that media decompression is not
available for steppings A0-C0.
If we test the latest iHD with the latest drm-tip on a B-stepping,
for example, we would see corrupted video frames on the display
by default.
This commit fixes this default behavior by disabling E2E compression
until media decompression is available.
This fixes #1029.
[1]
media-driver/media_driver/linux/gen12/ddi/media_sku_wa_g12.cpp
Line 257 in d457d66
[2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=dbff5a8db9c630f61a892ab41a283445e01270f5