Add query support for HEVC features #866
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lwan108
reviewed
Mar 12, 2020
| features.bits.separate_colour_plane_supported = 0; | ||
| features.bits.scaling_list_supported = 1; | ||
| features.bits.amp_supported = 1; | ||
| features.bits.sao_supported = 0; |
There was a problem hiding this comment.
HEVC VDENC can support this
lwan108
reviewed
Mar 12, 2020
| features.bits.scaling_list_supported = 1; | ||
| features.bits.amp_supported = 1; | ||
| features.bits.sao_supported = 0; | ||
| features.bits.temporal_mvp_supported = 0; |
There was a problem hiding this comment.
HEVC VDENC can support this
lwan108
reviewed
Mar 12, 2020
| features.bits.pcm_supported = 0; | ||
| features.bits.strong_intra_smoothing_supported = 0; | ||
| features.bits.sign_data_hiding_supported = 0; | ||
| features.bits.transform_skip_supported = 0; |
There was a problem hiding this comment.
HEVC VDENC can support this
lwan108
reviewed
Mar 12, 2020
| features.bits.strong_intra_smoothing_supported = 0; | ||
| features.bits.sign_data_hiding_supported = 0; | ||
| features.bits.transform_skip_supported = 0; | ||
| features.bits.weighted_prediction_supported = 0; |
There was a problem hiding this comment.
HEVC VDENC can support this.
lwan108
reviewed
Mar 12, 2020
| // All transform sizes allowed, with no limit on the hierarchy. | ||
| features.bits.log2_max_luma_transform_block_size_minus2 = 3; | ||
| features.bits.log2_min_luma_transform_block_size_minus2 = 0; | ||
| features.bits.max_transform_hierarchy_depth_inter = 3; |
There was a problem hiding this comment.
Should be 2 for HEVC VDENC, same for max_transform_hierarchy_depth_intra
|
Also interested on: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a sufficient example to go with intel/libva#385 to get 4:2:2 encode working on Ice Lake. None of this is documented anywhere that I can find, so it is likely to be incomplete and break other cases.
(Are Ice Lake manuals available anywhere like the ones for earlier platforms at https://01.org/linuxgraphics/documentation/hardware-specification-prms ?)