Use media_type instead of content_type #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rails 6.0.0.rc2 changed the behaviour of the `content_type` method to include the `charset` media type parameter. This broke our content type check, which assumed no parameters would be present. A new `media_type` method was also added that returns the media type without parameters. We can fix the content type check on Rails 6.0 while staying compatible with older Rails versions by using the `media_type` method if it exists, and falling back to the `content_type` method otherwise.
jonnyom
approved these changes
Aug 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #312.
Rails 6.0.0.rc2 changed the behaviour of the
content_typemethod to include thecharsetmedia type parameter. This broke our content type check, which assumed no parameters would be present. A newmedia_typemethod was also added that returns the media type without parameters.We can fix the content type check on Rails 6.0 while staying compatible with older Rails versions by using the
media_typemethod if it exists, and falling back to thecontent_typemethod otherwise.