Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(GH-226): Support logging of the generated JPQL query string with debug log level #227

Merged
merged 5 commits into from
Dec 15, 2019

Conversation

igdianov
Copy link
Collaborator

@igdianov igdianov commented Dec 15, 2019

Fixes #226

Configured by DEBUG logging level on com.introproventures.graphql.jpa.query.schema package.

logging:
  level:
    com.introproventures.graphql.jpa.query.schema: DEBUG

Then, log output will produce:

2019-12-14 17:27:36.865  INFO 5868 --- [nio-8080-exec-8] c.i.g.j.q.s.i.GraphQLJpaQueryDataFetcher : 
GraphQL JPQL Query String:
    select distinct droid from Droid as droid left join fetch droid.friends as generatedAlias0 left join fetch generatedAlias0.friendsOf as generatedAlias1 where generatedAlias1.name=:param0 order by droid.id asc

@igdianov igdianov self-assigned this Dec 15, 2019
@codecov
Copy link

codecov bot commented Dec 15, 2019

Codecov Report

Merging #227 into master will increase coverage by 0.28%.
The diff coverage is 63.63%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #227      +/-   ##
============================================
+ Coverage     73.48%   73.76%   +0.28%     
- Complexity      845      856      +11     
============================================
  Files            49       49              
  Lines          3651     3698      +47     
  Branches        606      607       +1     
============================================
+ Hits           2683     2728      +45     
- Misses          704      706       +2     
  Partials        264      264
Impacted Files Coverage Δ Complexity Δ
.../query/schema/impl/GraphQLJpaQueryDataFetcher.java 88.57% <63.63%> (-2.92%) 27 <2> (+2)
...phql/jpa/query/schema/impl/GraphQLJpaExecutor.java 100% <0%> (ø) 4% <0%> (+1%) ⬆️
.../example/starwars/StarwarsSchemaConfiguration.java 100% <0%> (ø) 8% <0%> (+4%) ⬆️
.../query/example/books/BooksSchemaConfiguration.java 100% <0%> (ø) 7% <0%> (+3%) ⬆️
.../graphql/jpa/query/introspection/Constructors.java 82% <0%> (+4%) 15% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38bfb17...a3e5990. Read the comment docs.

@igdianov igdianov merged commit ad1d404 into master Dec 15, 2019
@igdianov igdianov deleted the fix-GH-226-log-jpql-query-string branch December 15, 2019 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support logging generated JPQL query string with debug log level
1 participant