Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy data loader registry lookup from execution context #357

Merged
merged 3 commits into from
Mar 9, 2023

Conversation

igdianov
Copy link
Collaborator

@igdianov igdianov commented Mar 9, 2023

No description provided.

@igdianov igdianov self-assigned this Mar 9, 2023
@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.10 ⚠️

Comparison is base (f7fbd31) 74.92% compared to head (0e9b020) 74.83%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #357      +/-   ##
============================================
- Coverage     74.92%   74.83%   -0.10%     
+ Complexity     1151     1148       -3     
============================================
  Files            75       75              
  Lines          5017     4999      -18     
  Branches        724      717       -7     
============================================
- Hits           3759     3741      -18     
+ Misses          947      946       -1     
- Partials        311      312       +1     
Impacted Files Coverage Δ
...phQLJpaQueryGraphQlExecutionAutoConfiguration.java 100.00% <ø> (+20.00%) ⬆️
.../query/autoconfigure/GraphQLSchemaFactoryBean.java 80.91% <100.00%> (+0.14%) ⬆️
...a/query/schema/impl/GraphQLJpaExecutorContext.java 100.00% <100.00%> (ø)
...query/schema/impl/GraphQLJpaToManyDataFetcher.java 100.00% <100.00%> (ø)
.../query/schema/impl/GraphQLJpaToOneDataFetcher.java 70.37% <100.00%> (-1.06%) ⬇️

... and 5 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@igdianov igdianov merged commit 97fafa9 into master Mar 9, 2023
@igdianov igdianov deleted the fix-remove-legacy-dataloaderregistry branch March 9, 2023 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant